lgtm with comments.
https://codereview.chromium.org/1276353004/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1276353004/diff/1/src/objects.cc#newcode7971
src/objects.cc:7971: if (WeakCell::cast(element)->cleared()) continue;
Can we assert that we don't find PrototypeInfo objects here?
https://codereview.chromium.org/1276353004/diff/1/src/objects.cc#newcode7979
src/objects.cc:7979: void WeakFixedArray::CompactPrototypeUserList() {
This is essentially Compact() with an additional block inside the loop.
Can we deduplicate by using template, or a flag?
https://codereview.chromium.org/1276353004/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1276353004/diff/1/src/objects.h#newcode2543
src/objects.h:2543: void CompactPrototypeUserList();
Not sure if this should live on Map instead.
https://codereview.chromium.org/1276353004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
