On 2015/08/08 20:59:45, Jakob wrote:
Yang, I needed a workaround in the serializer to make sure
remembered-slot-updating on compaction doesn't happen too late. Is patch set 3 acceptable, or should we do that differently? Is there maybe a pass over the
heap before actual serialization that could take care of WeakFixedArray
compaction?

There is a GC before the actual serialization, but I'm not sure we want to do the compaction during GC. Since this does not affect the code serializer, but only the start-up snapshot, the creation of which is not performance-critical,
we could add a heap walk in V8::CreateSnapshotDataBlob to find all prototype
info objects to compact them before we actually serialize.

I'd be fine with landing this first and then prettify this in a follow-up.

https://codereview.chromium.org/1276353004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to