https://codereview.chromium.org/1287063004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1287063004/diff/1/src/parser.cc#newcode4328
src/parser.cc:4328: Expression* param =
I think this should be called "initializer"
https://codereview.chromium.org/1287063004/diff/1/src/parser.cc#newcode4342
src/parser.cc:4342: parameter.pattern, parameter.pattern->position(),
param);
The above-suggested renaming would make the callsite clearer.
https://codereview.chromium.org/1287063004/diff/1/src/preparser.h
File src/preparser.h (left):
https://codereview.chromium.org/1287063004/diff/1/src/preparser.h#oldcode3625
src/preparser.h:3625: bool is_rest, FormalParametersT* parameters,
This rest refactoring seems separate, could it be broken into another
patch if it's a prerequisite or dropped if it's a separate concern?
https://codereview.chromium.org/1287063004/diff/1/test/mjsunit/harmony/default-parameters.js
File test/mjsunit/harmony/default-parameters.js (right):
https://codereview.chromium.org/1287063004/diff/1/test/mjsunit/harmony/default-parameters.js#newcode84
test/mjsunit/harmony/default-parameters.js:84: (function
TestParameterScoping() {
This test looks like it could use some cases with more complex evals,
e.g., those that declare variables with "var" and "let" (in both strict
and sloppy modes).
https://codereview.chromium.org/1287063004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
