https://codereview.chromium.org/1287063004/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1287063004/diff/1/src/parser.cc#newcode4328
src/parser.cc:4328: Expression* param =
On 2015/08/12 18:22:59, adamk wrote:
I think this should be called "initializer"
That would confuse it with the actual initializer expression. I renamed
it to initial_value instead, is that okay?
https://codereview.chromium.org/1287063004/diff/1/src/parser.cc#newcode4342
src/parser.cc:4342: parameter.pattern, parameter.pattern->position(),
param);
On 2015/08/12 18:22:59, adamk wrote:
The above-suggested renaming would make the callsite clearer.
Done.
https://codereview.chromium.org/1287063004/diff/1/src/preparser.h
File src/preparser.h (left):
https://codereview.chromium.org/1287063004/diff/1/src/preparser.h#oldcode3625
src/preparser.h:3625: bool is_rest, FormalParametersT* parameters,
On 2015/08/12 18:22:59, adamk wrote:
This rest refactoring seems separate, could it be broken into another
patch if
it's a prerequisite or dropped if it's a separate concern?
Split into separate CL: https://codereview.chromium.org/1286133003
https://codereview.chromium.org/1287063004/diff/1/test/mjsunit/harmony/default-parameters.js
File test/mjsunit/harmony/default-parameters.js (right):
https://codereview.chromium.org/1287063004/diff/1/test/mjsunit/harmony/default-parameters.js#newcode84
test/mjsunit/harmony/default-parameters.js:84: (function
TestParameterScoping() {
On 2015/08/12 18:22:59, adamk wrote:
This test looks like it could use some cases with more complex evals,
e.g.,
those that declare variables with "var" and "let" (in both strict and
sloppy
modes).
Since these don't actually work correctly yet I just added a TODO.
https://codereview.chromium.org/1287063004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
