LGTM
http://codereview.chromium.org/573003/diff/5002/8008 File src/stub-cache.h (right): http://codereview.chromium.org/573003/diff/5002/8008#newcode394 src/stub-cache.h:394: Register CheckPrototypes(JSObject* object, Add vertical space between the function declarations? http://codereview.chromium.org/573003/diff/5002/8013 File test/cctest/test-api.cc (right): http://codereview.chromium.org/573003/diff/5002/8013#newcode5851 test/cctest/test-api.cc:5851: GenerateSomeGarbage(); Could you document why you generate some extra garbage in all of these tests? http://codereview.chromium.org/573003/diff/5002/8013#newcode5855 test/cctest/test-api.cc:5855: "for (var i = 0; i < 1000; i++) {" I think we use 1000 in other places as well, but do we need that many iterations? It is nice to have the tests run as fast as possible and still cover all the cases. http://codereview.chromium.org/573003 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
