lgtm
http://codereview.chromium.org/573003/diff/5002/8006 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/573003/diff/5002/8006#newcode803 src/ia32/stub-cache-ia32.cc:803: __ bind(&miss); feel free to ignore, but in case when !can_do_fast_api_call this adds unnecessary jump instruction---instead of branching to miss, we could immediately branch to miss_label. Apparently relatively easy to fix, but up to you. http://codereview.chromium.org/573003/diff/5002/8013 File test/cctest/test-api.cc (right): http://codereview.chromium.org/573003/diff/5002/8013#newcode5796 test/cctest/test-api.cc:5796: static v8::Handle<Value> InterceptorCallICFastApi(Local<String> name, I know that's boring, but apparently you didn't cover some cases like invalidation due to overriding in interceptor's holder-cached const function's holder chain. http://codereview.chromium.org/573003/diff/5002/8013#newcode5858 test/cctest/test-api.cc:5858: CHECK_EQ(42, context->Global()->Get(v8_str("result"))->Int32Value()); if you add result as a last line of script, you could use value here, might be more convenient http://codereview.chromium.org/573003 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
