LGTM with nits.
Very nice, I love it.
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h
File src/compiler/frame.h (right):
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode44
src/compiler/frame.h:44: // allocator and gab resolver with a
SpillSlotOperand containing its
Nit: gap resolver
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode63
src/compiler/frame.h:63: // 2 | JSFunction | |
|
Nit: Context
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode65
src/compiler/frame.h:65: // 3 | Marker | v
|
Nit: JSFunction/Marker
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/x64/code-generator-x64.cc
File src/compiler/x64/code-generator-x64.cc (right):
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/x64/code-generator-x64.cc#newcode1466
src/compiler/x64/code-generator-x64.cc:1466: }
Nit: add // namespace after } to make clang-format happy. Or maybe move
it to globals.h?
https://codereview.chromium.org/1261923007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
