Feedback addressed. I'll land this when all of the try bots are green.
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h
File src/compiler/frame.h (right):
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode44
src/compiler/frame.h:44: // allocator and gab resolver with a
SpillSlotOperand containing its
On 2015/08/16 at 07:04:35, Benedikt Meurer wrote:
Nit: gap resolver
Done
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode63
src/compiler/frame.h:63: // 2 | JSFunction | |
|
On 2015/08/16 at 07:04:35, Benedikt Meurer wrote:
Nit: Context
Done
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode65
src/compiler/frame.h:65: // 3 | Marker | v
|
On 2015/08/16 at 07:04:35, Benedikt Meurer wrote:
Nit: JSFunction/Marker
Done
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode84
src/compiler/frame.h:84: static const int kFixedSlotCount =
On 2015/08/17 at 10:58:42, titzer wrote:
I think this is dead now?
No, it's not. It is used to initialize the Frame with the initial number
of slots.
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/frame.h#newcode125
src/compiler/frame.h:125: ++spilled_callee_register_slot_count_ +=
count;
On 2015/08/16 at 09:31:34, Benedikt Meurer wrote:
Oh indeed. Missed this one. Should really be
frame_slot_count_ += count + 1;
Fixed.
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/x64/code-generator-x64.cc
File src/compiler/x64/code-generator-x64.cc (right):
https://codereview.chromium.org/1261923007/diff/290027/src/compiler/x64/code-generator-x64.cc#newcode1466
src/compiler/x64/code-generator-x64.cc:1466: }
On 2015/08/16 at 07:04:35, Benedikt Meurer wrote:
Nit: add // namespace after } to make clang-format happy. Or maybe
move it to globals.h?
Done
https://codereview.chromium.org/1261923007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
