Looks good except for an unneeded define check. I'll remove it prior to
committing.


http://codereview.chromium.org/600019/diff/1/3
File src/code-stubs.cc (right):

http://codereview.chromium.org/600019/diff/1/3#newcode67
src/code-stubs.cc:67: #if defined ENABLE_LOGGING_AND_PROFILING ||
defined ENABLE_OPROFILE_AGENT
A check for ENABLE_LOGGING_AND_PROFILING isn't needed here. In all other
places they are together because usually calculations are performed for
both reports. I'll remove the check prior to committing, leaving only
ENABLE_OPROFILE_AGENT.

http://codereview.chromium.org/600019

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to