https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h#newcode28
src/heap/heap.h:28: class HeapTester;
On 2015/08/20 13:33:37, Michael Starzinger wrote:
nit: No need for forward declare, friend declarations are implicit
forward
declarations (in the correct namespace).
Done.
https://codereview.chromium.org/1301183002/diff/40001/src/heap/heap.h#newcode2294
src/heap/heap.h:2294: // Currently set gc flags that are respected by
all components, e.g. Heap,
On 2015/08/20 13:33:37, Michael Starzinger wrote:
nit: s/gc/GC/
Done.
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc#newcode490
src/heap/incremental-marking.cc:490: StartMarking();
On 2015/08/20 13:33:37, Michael Starzinger wrote:
On 2015/08/20 13:06:29, Michael Lippautz wrote:
> Let's not reset the flags after kicking off incremental marking.
Acknowledged. Can we place a TODO in that regard here?
It's not a TODO. We should not reset them here, because a MarkSweep
finalizing incremental marking should respect these flags.
https://codereview.chromium.org/1301183002/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/mark-compact.cc#newcode788
src/heap/mark-compact.cc:788: // if (was_marked_incrementally_ &&
abort_incremental_marking_) {
On 2015/08/20 13:33:37, Michael Starzinger wrote:
Comment looks like a leftover.
Done.
https://codereview.chromium.org/1301183002/diff/40001/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/1301183002/diff/40001/test/cctest/test-debug.cc#newcode7319
test/cctest/test-debug.cc:7319: int CountNativeContexts();
On 2015/08/20 13:33:37, Michael Starzinger wrote:
Would "int v8::internal::CountNativeContexts();" also work here?
Nope, not possible in C++ as far as I know. Fully qualified names only
work for entities that already have been declared.
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
