LGTM from my end.
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc
File src/heap/incremental-marking.cc (right):
https://codereview.chromium.org/1301183002/diff/40001/src/heap/incremental-marking.cc#newcode490
src/heap/incremental-marking.cc:490: StartMarking();
On 2015/08/20 15:46:28, Michael Lippautz wrote:
On 2015/08/20 13:33:37, Michael Starzinger wrote:
> On 2015/08/20 13:06:29, Michael Lippautz wrote:
> > Let's not reset the flags after kicking off incremental marking.
>
> Acknowledged. Can we place a TODO in that regard here?
It's not a TODO. We should not reset them here, because a MarkSweep
finalizing
incremental marking should respect these flags.
Acknowledged. Ah, now I understand, this comment was about the removal
of the line below. Got it. Sorry!
https://codereview.chromium.org/1301183002/diff/40001/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/1301183002/diff/40001/test/cctest/test-debug.cc#newcode7319
test/cctest/test-debug.cc:7319: int CountNativeContexts();
On 2015/08/20 15:46:29, Michael Lippautz wrote:
On 2015/08/20 13:33:37, Michael Starzinger wrote:
> Would "int v8::internal::CountNativeContexts();" also work here?
Nope, not possible in C++ as far as I know. Fully qualified names only
work for
entities that already have been declared.
Acknowledged.
https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc#newcode2814
test/cctest/test-heap.cc:2814: CHECK_EQ(true, heap->current_gc_flags() &
Heap::kReduceMemoryFootprintMask);
nit: Comparison of boolean with integer looks fishy. Can we use ...
CHECK_NE(0, heap->current_gc_flags() &
Heap::kReduceMemoryFootprintMask);
https://codereview.chromium.org/1301183002/diff/80001/test/cctest/test-heap.cc#newcode2817
test/cctest/test-heap.cc:2817: CHECK_EQ(true, heap->current_gc_flags() &
Heap::kReduceMemoryFootprintMask);
nit: Likewise.
https://codereview.chromium.org/1301183002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
