On 2015/08/20 21:35:47, bradn wrote:
PTAL
That it much niced not needing to plumb in the zone.
I've sent out separate CL to change typing.h similarly.
I also looked at one of the items in hydrogen.h too that uses this
pattern,
but
it appears to actually need it, as that object gets handed to an
OptimizedCompileJob, which is also Zone allocated, but I'm unsure if the
zone
outlives the scope.
OptimizedCompileJobs go between threads, so it's likely they do. I didn't
look
into this case yet, tho.
https://codereview.chromium.org/1288773007/diff/140001/src/typing-reset.cc
File src/typing-reset.cc (right):
https://codereview.chromium.org/1288773007/diff/140001/src/typing-reset.cc#newcode22
src/typing-reset.cc:22: TypingReseter* visitor = new (info->zone())
TypingReseter(info);
On 2015/08/20 16:34:26, rossberg wrote:
> No need to heap-allocate the visitor, AFAICT.
Ok, changed round.
By the way, a terminology question.
You referred to this as heap-allocation, but I had the impression that
usually
refers to allocation in V8's GC heap? Whereas isn't this just in a Zone
scoped
to this particular compile? Or have I misunderstood something about Zones
+ GC
heap?
https://codereview.chromium.org/1288773007/diff/140001/test/cctest/expression-type-collector.cc
File test/cctest/expression-type-collector.cc (right):
https://codereview.chromium.org/1288773007/diff/140001/test/cctest/expression-type-collector.cc#newcode32
test/cctest/expression-type-collector.cc:32: ExpressionTypeCollector*
visitor
=
On 2015/08/20 16:34:26, rossberg wrote:
> Same here, no reason for heap allocation.
Done.
https://codereview.chromium.org/1288773007/diff/140001/test/cctest/expression-type-collector.h
File test/cctest/expression-type-collector.h (right):
https://codereview.chromium.org/1288773007/diff/140001/test/cctest/expression-type-collector.h#newcode13
test/cctest/expression-type-collector.h:13: // Macros to define checking
of a
tree walk.
On 2015/08/20 16:34:27, rossberg wrote:
> That's some fancy macro fu there! :)
Not sure whether that's a compliment of an insult :-)
Too much, or ok?
https://codereview.chromium.org/1288773007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
