https://codereview.chromium.org/1288773007/diff/140001/src/typing-reset.cc
File src/typing-reset.cc (right):
https://codereview.chromium.org/1288773007/diff/140001/src/typing-reset.cc#newcode22
src/typing-reset.cc:22: TypingReseter* visitor = new (info->zone())
TypingReseter(info);
On 2015/08/20 21:35:47, bradn wrote:
By the way, a terminology question.
You referred to this as heap-allocation, but I had the impression that
usually
refers to allocation in V8's GC heap? Whereas isn't this just in a
Zone scoped
to this particular compile? Or have I misunderstood something about
Zones + GC
heap?
I was just being sloppy. Meant heap-allocated as opposed to
stack-allocated.
https://codereview.chromium.org/1288773007/diff/140001/test/cctest/expression-type-collector.h
File test/cctest/expression-type-collector.h (right):
https://codereview.chromium.org/1288773007/diff/140001/test/cctest/expression-type-collector.h#newcode13
test/cctest/expression-type-collector.h:13: // Macros to define checking
of a tree walk.
On 2015/08/20 21:35:47, bradn wrote:
On 2015/08/20 16:34:27, rossberg wrote:
> That's some fancy macro fu there! :)
Not sure whether that's a compliment of an insult :-)
Too much, or ok?
Can't make up my mind. :) I think it's fine and useful for tests, but
perhaps would be too much in "real" code.
https://codereview.chromium.org/1288773007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
