https://codereview.chromium.org/1300103005/diff/100001/src/expression-classifier.h File src/expression-classifier.h (right):
https://codereview.chromium.org/1300103005/diff/100001/src/expression-classifier.h#newcode235 src/expression-classifier.h:235: // parameter Nit: period https://codereview.chromium.org/1300103005/diff/100001/src/preparser.cc File src/preparser.cc (right): https://codereview.chromium.org/1300103005/diff/100001/src/preparser.cc#newcode270 src/preparser.cc:270: if (!scope_->HasSimpleParameters()) { Nit: merge conditions https://codereview.chromium.org/1300103005/diff/100001/src/preparser.cc#newcode271 src/preparser.cc:271: // A block declaration scope as a child scope of a function scope Not sure how the comment relates to the code. Which block scope? https://codereview.chromium.org/1300103005/diff/100001/src/preparser.h File src/preparser.h (right): https://codereview.chromium.org/1300103005/diff/100001/src/preparser.h#newcode2860 src/preparser.h:2860: bool is_simple = arrow_formals_classifier.is_simple_parameter_list(); Nit: avoid the extra variable by storing to parameters.is_simple directly. https://codereview.chromium.org/1300103005/diff/100001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1300103005/diff/100001/test/cctest/test-parsing.cc#newcode6885 test/cctest/test-parsing.cc:6885: // A block declaration scope as a child scope of a function scope Same here. https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/destructuring.js File test/mjsunit/harmony/destructuring.js (right): https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/destructuring.js#newcode752 test/mjsunit/harmony/destructuring.js:752: }); Better call this function! https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/destructuring.js#newcode759 test/mjsunit/harmony/destructuring.js:759: }); Same here https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/destructuring.js#newcode790 test/mjsunit/harmony/destructuring.js:790: }); And here https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/rest-params.js File test/mjsunit/harmony/rest-params.js (right): https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/rest-params.js#newcode149 test/mjsunit/harmony/rest-params.js:149: "use strict"; This changes the test. Make sure that the caller remains in sloppy mode. https://codereview.chromium.org/1300103005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
