https://codereview.chromium.org/1300103005/diff/100001/src/expression-classifier.h
File src/expression-classifier.h (right):
https://codereview.chromium.org/1300103005/diff/100001/src/expression-classifier.h#newcode235
src/expression-classifier.h:235: // parameter
On 2015/08/24 13:11:08, rossberg wrote:
Nit: period
Done.
https://codereview.chromium.org/1300103005/diff/100001/src/preparser.cc
File src/preparser.cc (right):
https://codereview.chromium.org/1300103005/diff/100001/src/preparser.cc#newcode270
src/preparser.cc:270: if (!scope_->HasSimpleParameters()) {
On 2015/08/24 13:11:08, rossberg wrote:
Nit: merge conditions
Done.
https://codereview.chromium.org/1300103005/diff/100001/src/preparser.cc#newcode271
src/preparser.cc:271: // A block declaration scope as a child scope of a
function scope
On 2015/08/24 13:11:08, rossberg wrote:
Not sure how the comment relates to the code. Which block scope?
I think this is referring to HasSimpleParameters looking up the flag in
the ClosureScope. I've reworded it anyway.
https://codereview.chromium.org/1300103005/diff/100001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1300103005/diff/100001/src/preparser.h#newcode2860
src/preparser.h:2860: bool is_simple =
arrow_formals_classifier.is_simple_parameter_list();
On 2015/08/24 13:11:08, rossberg wrote:
Nit: avoid the extra variable by storing to parameters.is_simple
directly.
Done.
https://codereview.chromium.org/1300103005/diff/100001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1300103005/diff/100001/test/cctest/test-parsing.cc#newcode6885
test/cctest/test-parsing.cc:6885: // A block declaration scope as a
child scope of a function scope
On 2015/08/24 13:11:08, rossberg wrote:
Same here.
Done.
https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/destructuring.js#newcode752
test/mjsunit/harmony/destructuring.js:752: });
On 2015/08/24 13:11:08, rossberg wrote:
Better call this function!
Done.
https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/destructuring.js#newcode759
test/mjsunit/harmony/destructuring.js:759: });
On 2015/08/24 13:11:08, rossberg wrote:
Same here
Done.
https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/destructuring.js#newcode790
test/mjsunit/harmony/destructuring.js:790: });
On 2015/08/24 13:11:08, rossberg wrote:
And here
Done.
https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/rest-params.js
File test/mjsunit/harmony/rest-params.js (right):
https://codereview.chromium.org/1300103005/diff/100001/test/mjsunit/harmony/rest-params.js#newcode149
test/mjsunit/harmony/rest-params.js:149: "use strict";
On 2015/08/24 13:11:08, rossberg wrote:
This changes the test. Make sure that the caller remains in sloppy
mode.
Done.
https://codereview.chromium.org/1300103005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
