Cool, a ton of more work left...
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24 16:36:36, Michael Lippautz wrote:
Any reason this debug method using prints is inlined?
Be gone.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1047
src/heap/heap.h:1047: intptr_t
CalculateOldGenerationAllocationLimit(double factor,
CalculateOldGenerationAllocationLimit and
SetOldGenerationAllocationLimit should also be private and should go
where DampenOldGenerationAllocationLimit went. We can also make a "heap
growing strategy section"
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1090
src/heap/heap.h:1090: inline bool ShouldBePromoted(Address old_address,
int object_size);
Also a private.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1102
src/heap/heap.h:1102: inline bool OldGenerationAllocationLimitReached();
This one should also be next to the other growing strategy functions.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1108
src/heap/heap.h:1108: bool RecentIdleNotificationHappened();
Private. There should be a section for them.
https://codereview.chromium.org/1313513003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
