Nice. I love it. LGTM.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h
File src/heap/heap-inl.h (left):
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap-inl.h#oldcode326
src/heap/heap-inl.h:326: void Heap::PrintAlloctionsHash() {
On 2015/08/24 16:36:36, Michael Lippautz wrote:
Any reason this debug method using prints is inlined?
Nah, can't think of any. Probably just to have is "close" to
Heap::UpdateAllocationsHash above. Moving to the heap.cc files looks
fine to me.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1707
src/heap/heap.h:1707: void GarbageCollectionEpilogue();
Can both go into the "Actual GC" section as well, probably near the top
of that section, as it is common to scavenge and full GC.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1766
src/heap/heap.h:1766: void Scavenge();
Can go into the "Actual GC" section, right before DoScavenge.
https://codereview.chromium.org/1313513003/diff/1/src/heap/heap.h#newcode1778
src/heap/heap.h:1778: void ProcessAllocationSites(WeakObjectRetainer*
retainer);
Can both go into the "Actual GC" section after ProcessAllWeakReferences
and ProcessYoungWeakReferences.
https://codereview.chromium.org/1313513003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
