LGTM.
Will you include the change for the x64 back-end? I think we should keep
them in
sync.
http://codereview.chromium.org/606015/diff/1/2
File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/606015/diff/1/2#newcode3997
src/ia32/codegen-ia32.cc:3997: Result result;
I'd move the declaration into the innermost necessary scope because it
is not used on some paths.
http://codereview.chromium.org/606015/diff/1/2#newcode3999
src/ia32/codegen-ia32.cc:3999: ASSERT(slot->var()->is_dynamic());
Declare result here instead.
http://codereview.chromium.org/606015/diff/1/2#newcode4015
src/ia32/codegen-ia32.cc:4015: Slot* potential_slot =
slot->var()->local_if_not_shadowed()->slot();
Declare result here.
http://codereview.chromium.org/606015/diff/1/2#newcode4076
src/ia32/codegen-ia32.cc:4076: return frame()->Pop();
Would it make sense to have a virtual frame function
"Result getParameterAt(index)" or
"Result getLocalAt(index)" instead of pushing/popping?
http://codereview.chromium.org/606015/diff/1/2#newcode4083
src/ia32/codegen-ia32.cc:4083: // The other remaining slot types (LOOKUP
and GLOBAL) cannot reach
Declare result here.
http://codereview.chromium.org/606015
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
