http://codereview.chromium.org/606015/diff/1/2 File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/606015/diff/1/2#newcode3997 src/ia32/codegen-ia32.cc:3997: Result result; On 2010/02/12 12:23:06, fschneider wrote:
I'd move the declaration into the innermost necessary scope because it
is not
used on some paths.
Ultimately it will be a field in the codegen state, so I really want one declaration at the very top of the function (so it's easy to remove) called result (so it's easy to search for). http://codereview.chromium.org/606015/diff/1/2#newcode4076 src/ia32/codegen-ia32.cc:4076: return frame()->Pop(); On 2010/02/12 12:23:06, fschneider wrote:
Would it make sense to have a virtual frame function "Result getParameterAt(index)" or "Result getLocalAt(index)" instead of pushing/popping?
Yes, and PushParameterAt should go away. That's a separate change I'll make after it's no longer used. http://codereview.chromium.org/606015 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
