LGTM on full codegen, just nits. But one concern about scope serialization,
adding Andreas for that.
https://codereview.chromium.org/1312613003/diff/60001/src/full-codegen/full-codegen.cc
File src/full-codegen/full-codegen.cc (right):
https://codereview.chromium.org/1312613003/diff/60001/src/full-codegen/full-codegen.cc#newcode1588
src/full-codegen/full-codegen.cc:1588: bool
FullCodeGenerator::NeedsHoleCheck(VariableProxy* proxy) {
nit: Can we call this predicate either "NeedsHoleCheckOnLoad" or
"NeedsHoleCheckForLoad", otherwise people might get the idea to use this
for assignments at some point and become disappointed.
https://codereview.chromium.org/1312613003/diff/60001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1312613003/diff/60001/src/scopes.h#newcode232
src/scopes.h:232: void SetNonlinear() { scope_nonlinear_ = true; }
Isn't it necessary to serialize this flag into the ScopeInfo? Adding
Andreas whose scoping foo is clearly superior to mine.
https://codereview.chromium.org/1312613003/diff/60001/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):
https://codereview.chromium.org/1312613003/diff/60001/test/mjsunit/mjsunit.status#newcode159
test/mjsunit/mjsunit.status:159: 'regress/regress-3926': [PASS,
NO_VARIANTS],
This should no longer be needed after my fix for issue 4388 that already
landed.
https://codereview.chromium.org/1312613003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
