On 2015/08/26 12:07:58, rossberg wrote:
https://codereview.chromium.org/1312613003/diff/60001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1312613003/diff/60001/src/scopes.h#newcode232
src/scopes.h:232: void SetNonlinear() { scope_nonlinear_ = true; }
On 2015/08/26 11:30:30, Michael Starzinger wrote:
> Isn't it necessary to serialize this flag into the ScopeInfo? Adding
Andreas
> whose scoping foo is clearly superior to mine.
Indeed, AFAICS this flag needs to be de/serialized in scopeinfos,
otherwise
lazily compiled local functions inside switch blocks will still miss hole
checks. A test for that case would be good, too.
...and likewise in local evals, me thinks.
https://codereview.chromium.org/1312613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
