LGTM too.
http://codereview.chromium.org/596096/diff/1001/1006 File src/ia32/macro-assembler-ia32.h (right): http://codereview.chromium.org/596096/diff/1001/1006#newcode127 src/ia32/macro-assembler-ia32.h:127: void InvokeFunction(JSFunction* function, On 2010/02/12 20:32:40, Vitaly wrote:
I think this should either be named JumpFunction or take an
InvokeFlag. Also
this needs a comment.
Agreed. The usual naming is CallSomething and TailCallSomething. If you pass in an InvokeFlag you can call it InvokeFunction. http://codereview.chromium.org/596096 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
