I have a change that interacts with this somewhat on ARM. Could you look at it and make sure they are compatible: http://codereview.chromium.org/604054
On Mon, Feb 15, 2010 at 9:04 AM, <[email protected]> wrote: > LGTM too. > > > > http://codereview.chromium.org/596096/diff/1001/1006 > File src/ia32/macro-assembler-ia32.h (right): > > http://codereview.chromium.org/596096/diff/1001/1006#newcode127 > src/ia32/macro-assembler-ia32.h:127: void InvokeFunction(JSFunction* > function, > On 2010/02/12 20:32:40, Vitaly wrote: > >> I think this should either be named JumpFunction or take an >> > InvokeFlag. Also > >> this needs a comment. >> > > Agreed. The usual naming is CallSomething and TailCallSomething. If > you pass in an InvokeFlag you can call it InvokeFunction. > > > http://codereview.chromium.org/596096 > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- William Hesse Software Engineer [email protected] Google Denmark ApS Frederiksborggade 20B, 1 sal 1360 København K Denmark CVR nr. 28 86 69 84 If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
