Thanks, Mads.
I've added a test into array-shift.js which is pretty much the test from
array-functions-prototype.js. If it's not enough, just let me know and I'd
add
some more tests.
http://codereview.chromium.org/606017/diff/1/3
File src/builtins.cc (right):
http://codereview.chromium.org/606017/diff/1/3#newcode354
src/builtins.cc:354: // Set the length.
On 2010/02/15 07:47:03, Mads Ager wrote:
Move the setting on the new length after the optional getting on the
first
element from the prototype (which is part of getting the first element
so
belongs with elms->get(0) above).
Done.
http://codereview.chromium.org/606017/diff/1/3#newcode361
src/builtins.cc:361: for (int i = 0; i < len - 1; i++) {
On 2010/02/15 07:47:03, Mads Ager wrote:
Add a comment for consistency with the rest of the function? "Shift
the
elements."
Done.
http://codereview.chromium.org/606017/diff/1/5
File test/mjsunit/array-shift.js (right):
http://codereview.chromium.org/606017/diff/1/5#newcode28
test/mjsunit/array-shift.js:28: // Check that shifting array of holes
keeps it as arrary of holes
On 2010/02/15 07:47:03, Mads Ager wrote:
arrary -> array
Done.
http://codereview.chromium.org/606017
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
