Sure, please, have a look at http://codereview.chromium.org/596116/show

I'll add corresponding test for Array.unshift as well.

On 2010/02/15 11:10:54, Mads Ager wrote:
Still looks good.

http://codereview.chromium.org/606017/diff/4001/3005
File test/mjsunit/array-shift.js (right):

http://codereview.chromium.org/606017/diff/4001/3005#newcode45
test/mjsunit/array-shift.js:45: assertEquals(array[7], Array.prototype[7]);
I guess after shifting array[6] is interesting as well?



http://codereview.chromium.org/606017

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to