I'm checking the IS_CALLABLE replacements now. Most of them seem to be
perfectly
fine. But I guess there'll be weird corner cases where clusterfuzz will
tell us
that we did it wrong so far :-)
https://codereview.chromium.org/1316933002/diff/1/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/1316933002/diff/1/src/objects-debug.cc#newcode39
src/objects-debug.cc:39: CHECK(!IsCallable());
Don't know, but doable if you want, yeah.
https://codereview.chromium.org/1316933002/diff/1/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/1316933002/diff/1/src/promise.js#newcode262
src/promise.js:262: : PromiseIdResolveHandler;
On 2015/08/26 12:55:48, rossberg wrote:
Nit: should fit one line now (same below)
Done.
https://codereview.chromium.org/1316933002/diff/1/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/1316933002/diff/1/src/runtime/runtime-classes.cc#newcode107
src/runtime/runtime-classes.cc:107: } else if
(super_class->IsJSFunction()) {
Actually it should be IsConstructor, but we don't have that yet. Plus
there's a JSFunction cast on the next line. So I'll add a TODO and clean
it up later once we have proper IsConstructor.
https://codereview.chromium.org/1316933002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
