LGTM if all the changes to the .js file are working as intended from a
specification perspective, didn't check those.
https://codereview.chromium.org/1316933002/diff/80001/src/execution.h
File src/execution.h (right):
https://codereview.chromium.org/1316933002/diff/80001/src/execution.h#newcode119
src/execution.h:119: MUST_USE_RESULT static Handle<String>
RenderCallSite(Isolate* isolate,
nit: If the return value is Handle<> and not MaybeHandle<>, then not
using the result should be fine.
https://codereview.chromium.org/1316933002/diff/80001/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/1316933002/diff/80001/src/objects-debug.cc#newcode39
src/objects-debug.cc:39: CHECK(!IsCallable());
This CHECK does not really verify the Smi value, but is testing the
IsCallable predicate. Do we really want to have this? This seems more
like something that should be in some unittest somewhere.
https://codereview.chromium.org/1316933002/diff/80001/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/1316933002/diff/80001/src/runtime/runtime-classes.cc#newcode82
src/runtime/runtime-classes.cc:82: Handle<Symbol>
home_object_symbol(isolate->factory()->home_object_symbol());
nit: Use assignment instead of constructor for this.
https://codereview.chromium.org/1316933002/diff/80001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/1316933002/diff/80001/test/cctest/test-api.cc#newcode9799
test/cctest/test-api.cc:9799: strcmp("TypeError: object is not a
function", *exception_value2));
This will most likely hit blink layout tests. Better run one of the
try-jobs before landing.
https://codereview.chromium.org/1316933002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
