Just replying to comment. Will do review tomorrow.
https://codereview.chromium.org/1321663003/diff/40001/test/cctest/interpreter/test-bytecode-generator.cc
File test/cctest/interpreter/test-bytecode-generator.cc (right):
https://codereview.chromium.org/1321663003/diff/40001/test/cctest/interpreter/test-bytecode-generator.cc#newcode257
test/cctest/interpreter/test-bytecode-generator.cc:257: { 3.14, 3.14 }
On 2015/08/27 16:34:07, rmcilroy wrote:
Michi - looks like double literals aren't de-duped by the parser (we
get a new
HeapNumber each time). Is this done elsewhere or have we always had a
new
HeapNumber for each double literal?
Not sure I understand your comment correctly. How would the parser
de-dupe literals? That would make the AST degenerate into a DAG if we
would do that. Or am I missing something here?
Compilers can de-dupe the values. One mechanism of de-duping would be
GVN which makes sure that identical nodes in the graph are coalesced.
Both Hydrogen and TurboFan do that.
https://codereview.chromium.org/1321663003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
