Looking good. Just a few comments.
https://codereview.chromium.org/1321663003/diff/40001/src/DEPS
File src/DEPS (right):
https://codereview.chromium.org/1321663003/diff/40001/src/DEPS#newcode8
src/DEPS:8: "+src/heap/identity-map.h",
I have moved the IdentityMap out of the "heap" directory. This should no
longer be needed if you rebase.
https://codereview.chromium.org/1321663003/diff/40001/src/heap/identity-map.h
File src/heap/identity-map.h (right):
https://codereview.chromium.org/1321663003/diff/40001/src/heap/identity-map.h#newcode9
src/heap/identity-map.h:9: // Do not include anything from src/heap
here!
Likewise.
https://codereview.chromium.org/1321663003/diff/40001/src/interpreter/bytecode-array-builder.cc
File src/interpreter/bytecode-array-builder.cc (right):
https://codereview.chromium.org/1321663003/diff/40001/src/interpreter/bytecode-array-builder.cc#newcode55
src/interpreter/bytecode-array-builder.cc:55: if (constants_.size() ==
0) {
This special-casing is already part of Factory::NewFixedArray, it should
fall out naturally of the code below.
https://codereview.chromium.org/1321663003/diff/40001/src/interpreter/bytecode-array-builder.h
File src/interpreter/bytecode-array-builder.h (right):
https://codereview.chromium.org/1321663003/diff/40001/src/interpreter/bytecode-array-builder.h#newcode27
src/interpreter/bytecode-array-builder.h:27: explicit
BytecodeArrayBuilder(Isolate* isolate, Zone* zone);
nit: No longer needs to be marked as explicit.
https://codereview.chromium.org/1321663003/diff/40001/src/interpreter/bytecode-array-builder.h#newcode79
src/interpreter/bytecode-array-builder.h:79: std::vector<uint8_t>
bytecodes_;
Same comment from below applies here.
https://codereview.chromium.org/1321663003/diff/40001/src/interpreter/bytecode-array-builder.h#newcode83
src/interpreter/bytecode-array-builder.h:83: std::vector<Handle<Object>>
constants_;
Could we use a ZoneVector here, that would provide us with accounting
for the (zone) memory footprint of the interpreter later (i.e. similar
to --turbo-stats)
https://codereview.chromium.org/1321663003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
