Comment #19 on issue 3087 by [email protected]: ES6: Array.prototype.slice
and friends should use ToLength instead of ToUint32
https://code.google.com/p/v8/issues/detail?id=3087
@ #18: I have ran the Octane benchmarks without and with the patch, and
there is no significative difference. Most likely because the functions
which are changed to call ToLengthFlagged() only call it once and the cost
of the additional function call is amortized with the much bigger cost of
iterating over the array elements and performing operations on them. For
reference, those are the running times for the whole Octane, with 5 runs
discarding the faster and slower runs:
* Before the patch:
- 01:12.559
- 01:12.757
- 01:12.404
* After the patch:
- 01:12:280
- 01:12:414
- 01:12.987
In short: it seems that this patch would not incur any performance
regression for normal everyday JS code :-)
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
