Comment #23 on issue 3087 by [email protected]: ES6: Array.prototype.slice
and friends should use ToLength instead of ToUint32
https://code.google.com/p/v8/issues/detail?id=3087
Replying to myself:
In the TL;DR above maybe I shouldn't have jumped to conclusions saying that
the overhead is small. It would be actually better to have someone else who
is familiar with performance issues to take a look at the results.
On different note, I have an idea to avoid checking the “harmony_tolength”
boolean. First, we define:
var ToLengthFlagged = function (arg) { return TO_UINT32(arg); }
If the “--harmony-tolength” flag is enabled, we can just reassign:
ToLengthFlagged = ToLength;
This will avoid the extra function call when the flag is enabled, but it
will still involve a function call with the flag disabled, because
“TO_UINT32(x)” is a macro expanded at build time.
WDYT? If this approach sounds better, I will update the CL to add the
change.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
