lgtm % one more wingo comment I point to
https://codereview.chromium.org/1272673003/diff/110001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1272673003/diff/110001/src/parser.cc#newcode4414
src/parser.cc:4414: if (parameter.is_rest) {
On 2015/08/31 13:07:31, wingo wrote:
This should probably be "else if" and the previous case should
DCHECK(!parameter.is_rest), I think
Agreed on the else-if suggestion here.
https://codereview.chromium.org/1272673003/diff/110001/src/parser.cc#newcode4422
src/parser.cc:4422: DCHECK_NULL(parameter.initializer);
That'll get rid of this DCHECK (or rather replace it with the DCHECK
proposed by wingo)
https://codereview.chromium.org/1272673003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
