We're getting there.
https://codereview.chromium.org/1326613002/diff/80001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1326613002/diff/80001/src/heap/heap.cc#newcode1778
src/heap/heap.cc:1778: reinterpret_cast<v8::Isolate*>(isolate_)
amount_of_external_allocated_memory_ -= length;
https://codereview.chromium.org/1326613002/diff/80001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1326613002/diff/80001/src/heap/mark-compact.cc#newcode1870
src/heap/mark-compact.cc:1870: // If we end up needing more special
cases, we should factor this out.
Remove this comment.
https://codereview.chromium.org/1326613002/diff/80001/src/heap/mark-compact.cc#newcode4443
src/heap/mark-compact.cc:4443: // will be erroneously freed.
Replace to:
EvacuateNewSpaceAndCandidates iterates over new space objects and for
ArrayBuffers either re-registers them as live or promotes them. This is
needed to properly free them.
https://codereview.chromium.org/1326613002/diff/80001/src/heap/objects-visiting-inl.h
File src/heap/objects-visiting-inl.h (right):
https://codereview.chromium.org/1326613002/diff/80001/src/heap/objects-visiting-inl.h#newcode538
src/heap/objects-visiting-inl.h:538:
JSArrayBuffer::cast(object)->backing_store());
Can't we just call this as
heap->RegisterLiveArrayBuffer(
heap->InNewSpace(object),
JSArrayBuffer::cast(object)->backing_store()));
?
https://codereview.chromium.org/1326613002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
