lgtm -- let's try again; since we lack test coverage in this area be
prepared
that we might need to revert it
The next steps (if you would like to continue on this topic) would be
- Tests! (cannot emphasize this enough)
- Refactoring out in a separate class that is not embedded
- RegisterLiveArrayBuffer -> MarkLiveArrayBuffer
- Make those methods taking JSArrayBuffer and figure out whether
in_new_space is
true based on that.
https://codereview.chromium.org/1326613002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
