Pushed out the fixes that make the ArrayBufferTracker isolated. Going to see
what could be done with the tests. Should it be a separate CL?
https://codereview.chromium.org/1324023007/diff/20001/src/DEPS
File src/DEPS (right):
https://codereview.chromium.org/1324023007/diff/20001/src/DEPS#newcode8
src/DEPS:8: "+src/heap/array-buffer-tracker.h",
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Remove this one.
Acknowledged.
https://codereview.chromium.org/1324023007/diff/20001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/1324023007/diff/20001/src/api.cc#newcode35
src/api.cc:35: #include "src/heap/array-buffer-tracker.h"
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Include only src/heap/heap.h
Acknowledged, doesn't look like it is needed.
https://codereview.chromium.org/1324023007/diff/20001/src/api.cc#newcode6513
src/api.cc:6513:
isolate->heap()->array_buffer_tracker()->Unregister(*self);
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Use the wrapper call for Unregister.
Acknowledged.
https://codereview.chromium.org/1324023007/diff/20001/src/api.cc#newcode6722
src/api.cc:6722:
isolate->heap()->array_buffer_tracker()->Unregister(*self);
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Ditto.
Acknowledged.
https://codereview.chromium.org/1324023007/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1324023007/diff/20001/src/heap/heap.cc#newcode168
src/heap/heap.cc:168: array_buffer_tracker_ = new
ArrayBufferTracker(this);
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Move this into SetUp() somewhere next to ObjectStats.
The reason we do it this (in a separate SetUp call) way is that
initializer
order (= declaration order) does -- unfortunately -- not match with
the order we
need for some components.
Acknowledged.
https://codereview.chromium.org/1324023007/diff/20001/src/heap/heap.h
File src/heap/heap.h (left):
https://codereview.chromium.org/1324023007/diff/20001/src/heap/heap.h#oldcode1016
src/heap/heap.h:1016: void RegisterNewArrayBuffer(bool in_new_space,
void* data, size_t length);
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Create public wrapper calls only for RegisterNewArrayBuffer and
UnregisterNewArrayBuffer in Heap. These calls should forward and
provide the
interface into the heap.
Acknowledged.
https://codereview.chromium.org/1324023007/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1324023007/diff/20001/src/objects.cc#newcode30
src/objects.cc:30: #include "src/heap/array-buffer-tracker.h"
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Only include src/heap/heap.h
Acknowledged, doesn't look like it is needed.
https://codereview.chromium.org/1324023007/diff/20001/src/objects.cc#newcode15947
src/objects.cc:15947:
isolate->heap()->array_buffer_tracker()->RegisterNew(
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Use the wrapper call for Register.
Acknowledged.
https://codereview.chromium.org/1324023007/diff/20001/src/objects.cc#newcode16002
src/objects.cc:16002:
isolate->heap()->array_buffer_tracker()->RegisterNew(
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Ditto.
Acknowledged.
https://codereview.chromium.org/1324023007/diff/20001/src/runtime/runtime-typedarray.cc
File src/runtime/runtime-typedarray.cc (right):
https://codereview.chromium.org/1324023007/diff/20001/src/runtime/runtime-typedarray.cc#newcode9
src/runtime/runtime-typedarray.cc:9: #include
"src/heap/array-buffer-tracker.h"
On 2015/09/04 08:24:15, Michael Lippautz wrote:
Only include src/heap/heap.h
Acknowledged, doesn't look like it is needed.
https://codereview.chromium.org/1324023007/diff/20001/src/runtime/runtime-typedarray.cc#newcode96
src/runtime/runtime-typedarray.cc:96:
isolate->heap()->array_buffer_tracker()->Unregister(*array_buffer);
On 2015/09/04 08:24:16, Michael Lippautz wrote:
Use the wrapper call for Unregister.
Acknowledged.
https://codereview.chromium.org/1324023007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
