Since this is refactoring and almost done I am fine with a separate CL.
https://codereview.chromium.org/1324023007/diff/40001/src/heap/array-buffer-tracker.cc
File src/heap/array-buffer-tracker.cc (right):
https://codereview.chromium.org/1324023007/diff/40001/src/heap/array-buffer-tracker.cc#newcode32
src/heap/array-buffer-tracker.cc:32: bool in_new_space =
heap()->InNewSpace(buffer);
Move below !data check.
https://codereview.chromium.org/1324023007/diff/40001/src/heap/array-buffer-tracker.cc#newcode133
src/heap/array-buffer-tracker.cc:133: }
nit:
}
} // namespace internal
} // namespace v8
https://codereview.chromium.org/1324023007/diff/40001/src/heap/array-buffer-tracker.h
File src/heap/array-buffer-tracker.h (right):
https://codereview.chromium.org/1324023007/diff/40001/src/heap/array-buffer-tracker.h#newcode73
src/heap/array-buffer-tracker.h:73: }
nit:
};
} // namespace internal
} // namespace v8
https://codereview.chromium.org/1324023007/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1324023007/diff/40001/src/heap/heap.cc#newcode1978
src/heap/heap.cc:1978: void Heap::RegisterNewArrayBuffer(bool
in_new_space, void* data,
Anything holding us back to change the signature to take a
JSArrayBuffer* buffer? If not, please adjust.
https://codereview.chromium.org/1324023007/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1324023007/diff/40001/src/heap/heap.h#newcode1105
src/heap/heap.h:1105: inline ArrayBufferTracker* array_buffer_tracker()
{
nit: You can move this into the ArrayBufferTracker section.
https://codereview.chromium.org/1324023007/diff/40001/src/heap/heap.h#newcode1512
src/heap/heap.h:1512: // ArrayBufferTracker proxies.
===============================================
nit: Not an actual proxy. Remove this word please ;)
https://codereview.chromium.org/1324023007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
