On 2015/09/04 13:08:16, caitp wrote:
https://codereview.chromium.org/1309813007/diff/10001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1309813007/diff/10001/test/cctest/test-parsing.cc#newcode7078
test/cctest/test-parsing.cc:7078: kError, NULL, 0, always_flags,
arraysize(always_flags));
On 2015/09/04 12:39:30, wingo wrote:
> Change to kSuccess? Not sure if the to-do is done tho.
Oops, forgot I deleted the comment.
I don't think we should fix this with destructuring assignment, because
it's
(as
noted above) not destructuring assignment. Maybe if in the middle of
ParseExpression(), the error should just be delegated until after the
expression, if a `=>` is found or not.
I'll see if I can send a patch to fix that
Hey Andy, PTAL --- It's sort of ugly, but I've added a mechanism to support
this. It looks like it can be mostly deleted once more features are
shipping,
too
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
