https://codereview.chromium.org/1309813007/diff/10001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1309813007/diff/10001/src/preparser.h#newcode708
src/preparser.h:708: }
On 2015/09/04 12:39:30, wingo wrote:
I don't see how you are going to implement the desugaring without
implementing
an internal version of do expressions, and if you have done that then
it seems
to me that the rewrite can be pushed down into the main body of
ParseAssignmentExpression. WDYT?
Or are you doing this here because it could be that the expression is
a valid
assignmentexpression but actually is an arrow function formal
parameter? I
guess that's possible too. In any case I think a comment is warranted
:)
IteratorDestructuringAssignmentEvaluation may require some kind of
do-expression for desugaring, I guess. It might be doable with crazy
ternary expression chains, but that seems horrible, and would produce a
scary amount of code.
So I guess the destructuring version is blocked on something like that.
https://codereview.chromium.org/1309813007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
