Reviewers: jochen,
Description:
[presubmit] Enable build/c++11 linter checking.
This enables the general linter checking for "build/c++11" violations
during presubmit and instead marks the few known exceptions that we
allow explicitly.
[email protected]
Please review this at https://codereview.chromium.org/1317463007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+4, -5 lines):
M include/v8.h
M src/codegen.cc
M tools/presubmit.py
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
ab5056d699a767862c20b59c0d26675f210d675f..54c6dcd92c9739da6c01da01e4f278a6faa6de45
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -815,7 +815,7 @@ class Global : public PersistentBase<T> {
/**
* Move constructor.
*/
- V8_INLINE Global(Global&& other) : PersistentBase<T>(other.val_) {
+ V8_INLINE Global(Global&& other) : PersistentBase<T>(other.val_) { //
NOLINT
other.val_ = nullptr;
}
V8_INLINE ~Global() { this->Reset(); }
@@ -823,7 +823,7 @@ class Global : public PersistentBase<T> {
* Move via assignment.
*/
template <class S>
- V8_INLINE Global& operator=(Global<S>&& rhs) {
+ V8_INLINE Global& operator=(Global<S>&& rhs) { // NOLINT
TYPE_CHECK(T, S);
if (this != &rhs) {
this->Reset();
@@ -835,7 +835,7 @@ class Global : public PersistentBase<T> {
/**
* Pass allows returning uniques from functions, etc.
*/
- Global Pass() { return static_cast<Global&&>(*this); }
+ Global Pass() { return static_cast<Global&&>(*this); } // NOLINT
/*
* For compatibility with Chromium's base::Bind (base::Passed).
Index: src/codegen.cc
diff --git a/src/codegen.cc b/src/codegen.cc
index
0b130e987515589b1cd93691627de885eeb629ab..4791fe0e2dc352941fcf28dbacc53e36ba437233
100644
--- a/src/codegen.cc
+++ b/src/codegen.cc
@@ -5,7 +5,7 @@
#include "src/codegen.h"
#if defined(V8_OS_AIX)
-#include <fenv.h>
+#include <fenv.h> // NOLINT(build/c++11)
#endif
#include "src/bootstrapper.h"
#include "src/compiler.h"
Index: tools/presubmit.py
diff --git a/tools/presubmit.py b/tools/presubmit.py
index
58c130e95f9ad8d9f39fde9b3eb5d8ef2dc62f4e..c11e89ddb872ae978c8bf92cd17c3754f08dfa0a
100755
--- a/tools/presubmit.py
+++ b/tools/presubmit.py
@@ -53,7 +53,6 @@ from subprocess import PIPE
# TODO(mstarzinger): Fix and re-enable readability/namespace
LINT_RULES = """
--build/c++11
-build/header_guard
+build/include_alpha
-build/include_what_you_use
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
