lgtm with suggestion
https://codereview.chromium.org/1324103003/diff/40001/tools/js2c.py
File tools/js2c.py (right):
https://codereview.chromium.org/1324103003/diff/40001/tools/js2c.py#newcode112
tools/js2c.py:112: lineno = lines.count("\n", 0, start) + 1
Does counting \n lead to a good result on windows? Is this equivalent to
the following?
len(lines[0:start-1].splitlines())
https://codereview.chromium.org/1324103003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
