Comment #7 on issue 4413 by [email protected]: Call sequence is
inconsistent and almost always wrong
https://code.google.com/p/v8/issues/detail?id=4413#c7
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744
commit ccbb4ff00f1d8f32fd9227cd7aba1723791e5744
Author: bmeurer <[email protected]>
Date: Tue Sep 08 07:50:22 2015
[builtins] Unify the various versions of [[Call]] with a Call builtin.
The new Call and CallFunction builtins supersede the current
CallFunctionStub (and CallIC magic) and will be the single bottleneck
for all calling, including the currently special Function.prototype.call
and Function.prototype.apply builtins, which had handwritten (and
not fully compliant) versions of CallFunctionStub, and also the
CallIC(s), which where also slightly different.
This also reduces the overhead for API function calls, which is still
unnecessary high, but let's do that step-by-step.
This also fixes a bunch of cases where the implicit ToObject for
sloppy receivers was done in the wrong context (in the caller
context instead of the callee context), which basically meant
that we allowed cross context access to %ObjectPrototype%.
MIPS and MIPS64 ports contributed by [email protected].
[email protected], [email protected], [email protected]
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg
BUG=v8:4413
LOG=n
Committed: https://crrev.com/ef268a83be4dead004047c25b702319ea4be7277
Cr-Commit-Position: refs/heads/master@{#30627}
Review URL: https://codereview.chromium.org/1311013008
Cr-Commit-Position: refs/heads/master@{#30629}
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/arm/builtins-arm.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/arm/code-stubs-arm.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/arm/macro-assembler-arm.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/arm/macro-assembler-arm.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/arm64/builtins-arm64.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/arm64/code-stubs-arm64.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/arm64/macro-assembler-arm64.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/arm64/macro-assembler-arm64.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/bailout-reason.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/builtins.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/code-stubs.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/contexts.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/ia32/assembler-ia32.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/ia32/assembler-ia32.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/ia32/builtins-ia32.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/ia32/code-stubs-ia32.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/ia32/macro-assembler-ia32.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/ia32/macro-assembler-ia32.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/mips/builtins-mips.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/mips/code-stubs-mips.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/mips/macro-assembler-mips.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/mips/macro-assembler-mips.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/mips64/builtins-mips64.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/mips64/code-stubs-mips64.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/mips64/macro-assembler-mips64.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/mips64/macro-assembler-mips64.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/objects.h
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/runtime.js
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/runtime/runtime-function.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/x64/builtins-x64.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/x64/code-stubs-x64.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/x64/macro-assembler-x64.cc
[modify]
http://crrev.com/ccbb4ff00f1d8f32fd9227cd7aba1723791e5744/src/x64/macro-assembler-x64.h
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
