Comment #10 on issue 4413 by [email protected]: Call sequence is inconsistent and almost always wrong
https://code.google.com/p/v8/issues/detail?id=4413#c10
The following revision refers to this bug:https://chromium.googlesource.com/v8/v8.git/+/b37907ff7f866873ddfbfc97670b43c19a5fc7f9
commit b37907ff7f866873ddfbfc97670b43c19a5fc7f9 Author: bmeurer <[email protected]> Date: Wed Sep 09 05:01:01 2015 [calls] Consistent call protocol for calls. The number of actual arguments should always be available, there's no point in trying to optimize away a simple assignment of an immediate to a register before some calls. The main motivation is to have a consistent state at the beginning of every function. Currently the arguments register (i.e. rax or eax) either contains the number of arguments or some random garbage depending on whether the callsite decided that the callee might need the information or not. This causes trouble with runtime implementations of functions that do not set internal_formal_parameter_count to the DontAdaptArguments sentinel (we don't have any of those yet), but also makes it impossible to sanity check the arguments in the callee, because the callee doesn't know whether the caller decided to pass the number of arguments or random garbage. BUG=v8:4413 LOG=n Review URL: https://codereview.chromium.org/1330033002 Cr-Commit-Position: refs/heads/master@{#30648}[modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/arm/lithium-codegen-arm.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/arm/macro-assembler-arm.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/arm64/lithium-codegen-arm64.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/arm64/macro-assembler-arm64.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/hydrogen-instructions.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/hydrogen-instructions.h [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/hydrogen.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/hydrogen.h [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/ia32/lithium-codegen-ia32.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/ia32/macro-assembler-ia32.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/mips/lithium-codegen-mips.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/mips/macro-assembler-mips.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/mips64/lithium-codegen-mips64.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/mips64/macro-assembler-mips64.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/x64/lithium-codegen-x64.cc [modify] http://crrev.com/b37907ff7f866873ddfbfc97670b43c19a5fc7f9/src/x64/macro-assembler-x64.cc
--You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at: https://code.google.com/hosting/settings -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
