Thank you for the feedback. Hopefully, all of it was addressed.
https://codereview.chromium.org/1313493005/diff/20001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/1313493005/diff/20001/src/accessors.cc#newcode105
src/accessors.cc:105: if (Name::Equals(name,
isolate->factory()->length_string())) {
On 2015/09/09 11:51:06, Jakob wrote:
Let's keep using the existing CheckForName helper:
if (!CheckForName(...) && !CheckForName(...) && !...) { return false;
}
Acknowledged.
https://codereview.chromium.org/1313493005/diff/20001/src/accessors.cc#newcode119
src/accessors.cc:119: // %TypedArray%.prototype is non-configurable, and
so are the following
On 2015/09/09 11:51:06, Jakob wrote:
outdated comment (there are no "following named properties" any more);
also it
correctly describes an incorrect implementation
Acknowledged.
https://codereview.chromium.org/1313493005/diff/20001/src/accessors.cc#newcode133
src/accessors.cc:133: // constructor
On 2015/09/09 11:51:07, Jakob wrote:
nit: trailing full stop
Remove the comment.
https://codereview.chromium.org/1313493005/diff/20001/src/accessors.cc#newcode136
src/accessors.cc:136: // If the middle-prototype does not override the
fast property -
On 2015/09/09 11:51:06, Jakob wrote:
s/ -/, then/
s/it's/its/
s/offset/offset./
Removed the comment, added the dot.
https://codereview.chromium.org/1313493005/diff/20001/src/accessors.cc#newcode139
src/accessors.cc:139:
JSReceiver::GetOwnPropertyAttributes(Handle<JSObject>(js_proto),
On 2015/09/09 11:51:06, Jakob wrote:
This should use JSReceiver::HasOwnProperty(), but see overall comment
I did it in a slightly different way... Hope it is ok.
https://codereview.chromium.org/1313493005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
