All fixed, thank you!
https://codereview.chromium.org/1313493005/diff/60001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/1313493005/diff/60001/src/accessors.cc#newcode113
src/accessors.cc:113: DescriptorArray* descriptors =
map->instance_descriptors();
On 2015/09/10 11:33:56, Jakob wrote:
Before this is safe, you need to bail out for dictionary maps:
if (map->is_dictionary_map()) return false;
I knew I should do this! :) Thanks!
https://codereview.chromium.org/1313493005/diff/60001/src/accessors.cc#newcode120
src/accessors.cc:120: // Check if the property is overridden in the
prototype chain.
On 2015/09/10 11:33:56, Jakob wrote:
s/overridden/defined/
Acknowledged.
https://codereview.chromium.org/1313493005/diff/60001/src/accessors.cc#newcode122
src/accessors.cc:122: if (it.state() == LookupIterator::NOT_FOUND)
return false;
On 2015/09/10 11:33:56, Jakob wrote:
if (!it.IsFound()) return false;
Acknowledged.
https://codereview.chromium.org/1313493005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
