Thanks for the reviews, I'll port to ia32, arm and arm64 now.
+v8-mips-ports: Could you port for mips/mips64 please?
https://codereview.chromium.org/1323463005/diff/60001/src/interpreter/bytecode-array-builder.h
File src/interpreter/bytecode-array-builder.h (right):
https://codereview.chromium.org/1323463005/diff/60001/src/interpreter/bytecode-array-builder.h#newcode71
src/interpreter/bytecode-array-builder.h:71: // |callable|, the receiver
should be in |receiver| and all subsiquent
On 2015/09/10 14:17:27, oth wrote:
nit s/subsiquent/subsequent/
Done.
https://codereview.chromium.org/1323463005/diff/60001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):
https://codereview.chromium.org/1323463005/diff/60001/src/x64/builtins-x64.cc#newcode1795
src/x64/builtins-x64.cc:1795: __
Call(masm->isolate()->builtins()->Call(), RelocInfo::CODE_TARGET);
On 2015/09/10 09:51:34, Benedikt Meurer wrote:
Hm, I think this should be Jump instead of Call+ret
As discussed offline, this requires popping and repushing the return
address on x64. Done.
https://codereview.chromium.org/1323463005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
