Reviewers: Mads Ager,
Description:
Fix issues with commit r3839
Fix broken condition.
Fixe some style issues.
Re-enabel part of a test which was turned off.
[email protected]
Please review this at http://codereview.chromium.org/647007
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/objects.cc
M test/cctest/test-api.cc
M test/mjsunit/setter-on-constructor-prototype.js
Index: src/objects.cc
===================================================================
--- src/objects.cc (revision 3893)
+++ src/objects.cc (working copy)
@@ -4829,7 +4829,7 @@
// Check the basic conditions for generating inline constructor code.
if (!FLAG_inline_new
|| !has_only_simple_this_property_assignments()
- || !this_property_assignments_count() > 0) {
+ || this_property_assignments_count() == 0) {
return false;
}
@@ -4840,7 +4840,7 @@
}
// Traverse the proposed prototype chain looking for setters for
properties of
- // the same names as are set by the inline constructor..
+ // the same names as are set by the inline constructor.
for (Object* obj = prototype;
obj != Heap::null_value();
obj = obj->GetPrototype()) {
Index: test/cctest/test-api.cc
===================================================================
--- test/cctest/test-api.cc (revision 3893)
+++ test/cctest/test-api.cc (working copy)
@@ -9630,10 +9630,7 @@
" this.x = 23"
"};"
"C2.prototype = { };"
- "C2.prototype.__proto__ = P;"
- ""
- ""
- "");
+ "C2.prototype.__proto__ = P;");
v8::Local<v8::Script> script;
script = v8::Script::Compile(v8_str("new C1();"));
@@ -9682,10 +9679,7 @@
" this.x = 23"
"};"
"C2.prototype = { };"
- "C2.prototype.__proto__ = P;"
- ""
- ""
- "");
+ "C2.prototype.__proto__ = P;");
v8::Local<v8::Script> script;
script = v8::Script::Compile(v8_str("new C1();"));
Index: test/mjsunit/setter-on-constructor-prototype.js
===================================================================
--- test/mjsunit/setter-on-constructor-prototype.js (revision 3893)
+++ test/mjsunit/setter-on-constructor-prototype.js (working copy)
@@ -108,4 +108,4 @@
}
RunTest(false);
-//RunTest(true);
+RunTest(true);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
