Revision: 3894
Author: [email protected]
Date: Thu Feb 18 01:41:47 2010
Log: Fix issues with commit r3839
Fix broken condition.
Fixe some style issues.
Re-enabel part of a test which was turned off.
[email protected]
Review URL: http://codereview.chromium.org/647007
http://code.google.com/p/v8/source/detail?r=3894
Modified:
/branches/bleeding_edge/src/objects.cc
/branches/bleeding_edge/test/cctest/test-api.cc
/branches/bleeding_edge/test/mjsunit/setter-on-constructor-prototype.js
=======================================
--- /branches/bleeding_edge/src/objects.cc Thu Feb 18 01:07:03 2010
+++ /branches/bleeding_edge/src/objects.cc Thu Feb 18 01:41:47 2010
@@ -4829,7 +4829,7 @@
// Check the basic conditions for generating inline constructor code.
if (!FLAG_inline_new
|| !has_only_simple_this_property_assignments()
- || !this_property_assignments_count() > 0) {
+ || this_property_assignments_count() == 0) {
return false;
}
@@ -4840,7 +4840,7 @@
}
// Traverse the proposed prototype chain looking for setters for
properties of
- // the same names as are set by the inline constructor..
+ // the same names as are set by the inline constructor.
for (Object* obj = prototype;
obj != Heap::null_value();
obj = obj->GetPrototype()) {
=======================================
--- /branches/bleeding_edge/test/cctest/test-api.cc Thu Feb 18 01:07:03 2010
+++ /branches/bleeding_edge/test/cctest/test-api.cc Thu Feb 18 01:41:47 2010
@@ -9630,10 +9630,7 @@
" this.x = 23"
"};"
"C2.prototype = { };"
- "C2.prototype.__proto__ = P;"
- ""
- ""
- "");
+ "C2.prototype.__proto__ = P;");
v8::Local<v8::Script> script;
script = v8::Script::Compile(v8_str("new C1();"));
@@ -9682,10 +9679,7 @@
" this.x = 23"
"};"
"C2.prototype = { };"
- "C2.prototype.__proto__ = P;"
- ""
- ""
- "");
+ "C2.prototype.__proto__ = P;");
v8::Local<v8::Script> script;
script = v8::Script::Compile(v8_str("new C1();"));
=======================================
--- /branches/bleeding_edge/test/mjsunit/setter-on-constructor-prototype.js
Thu Feb 18 01:07:03 2010
+++ /branches/bleeding_edge/test/mjsunit/setter-on-constructor-prototype.js
Thu Feb 18 01:41:47 2010
@@ -108,4 +108,4 @@
}
RunTest(false);
-//RunTest(true);
+RunTest(true);
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
