https://codereview.chromium.org/1230793002/diff/160001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1230793002/diff/160001/src/objects.cc#newcode997
src/objects.cc:997: if (!it->IsElement()) {
On 2015/10/02 08:05:27, Toon Verwaest wrote:
Rather than if (!it->IsElement()) etc, you can just use
Handle<Name> name = it->GetName();
if (name->IsSymbol() && Symbol::cast(*name)->is_well_known_symbol()) {
return it->factory()->undefined_value();
}
GetName() converts elements to strings, which isn't needed, but name()
has a DCHECK(!IsElement()). So, it seemed better to avoid the
allocation, from my pov.
I can change it if people prefer that
https://codereview.chromium.org/1230793002/diff/160001/src/objects.cc#newcode1001
src/objects.cc:1001:
RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(it->isolate(), Object);
On 2015/10/02 08:05:27, Toon Verwaest wrote:
I don't see why this statement (RETURN_EX..) is needed.
I guess it isn't really needed, will remove
https://codereview.chromium.org/1230793002/diff/160001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1230793002/diff/160001/src/objects.h#newcode1217
src/objects.h:1217: LanguageMode language_mode = SLOPPY);
On 2015/10/02 08:05:27, Toon Verwaest wrote:
This declaration can now be dropped.
Acknowledged.
https://codereview.chromium.org/1230793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
