Thanks a lot, Kevin. On 2010/02/18 12:08:31, Kevin Millikin wrote:
Some small comments.
http://codereview.chromium.org/647013/diff/1/4 File src/ia32/ic-ia32.cc (right):
http://codereview.chromium.org/647013/diff/1/4#newcode1468 src/ia32/ic-ia32.cc:1468: Register receiver = edx; Make these const Register.
http://codereview.chromium.org/647013/diff/1/4#newcode1500 src/ia32/ic-ia32.cc:1500: // Prepare tail call to StoreIC_Miss This whole code snippet is
GenerateMiss(masm);
http://codereview.chromium.org/647013/diff/1/5 File src/ic.cc (right):
http://codereview.chromium.org/647013/diff/1/5#newcode1360 src/ic.cc:1360: Object* StoreIC_ArrayLength(Arguments args) { Please put NoHandleAllocation in this function, and ASSERT that the args
length
is as expected.
http://codereview.chromium.org/647013 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
