Forgotten responses. And I'd do port to other platforms if it's lgtm.
http://codereview.chromium.org/647013/diff/1/4 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/647013/diff/1/4#newcode1500 src/ia32/ic-ia32.cc:1500: // Prepare tail call to StoreIC_Miss On 2010/02/18 12:08:31, Kevin Millikin wrote:
This whole code snippet is
GenerateMiss(masm);
Oh yes, I am an idiot, thanks a lot for spotting this. http://codereview.chromium.org/647013/diff/1/5 File src/ic.cc (right): http://codereview.chromium.org/647013/diff/1/5#newcode1360 src/ic.cc:1360: Object* StoreIC_ArrayLength(Arguments args) { On 2010/02/18 12:08:31, Kevin Millikin wrote:
Please put NoHandleAllocation in this function, and ASSERT that the
args length
is as expected.
Done. http://codereview.chromium.org/647013 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
